-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org_text adjustments #921
org_text adjustments #921
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for this, @to-sta! Are you planning on adding Toast yourself, or should I check this? And let me know what changes should generally happen in the organization store :) |
@andrewtavis I will give it a try, with vue-sonner. We don't need the OrganizationText POST request anymore in the store. I can remove it myself while working on the toast 🤗 |
Sounds good! Thanks, @to-sta! |
Removed OrganizationText request and added in the vue sonner toast in the bottom left. |
Nice, @to-sta! Should I look into the conflicts from here? Let me know :) |
Yeah, that would be great. But I think instead of resolving 150 conflicts for versions, it would be more effective to re-compile the dependencies. You could remove the |
Ah ya, 100% @to-sta :) I don't deal with |
@@ -117,6 +118,8 @@ | |||
|
|||
<script setup lang="ts"> | |||
import type { OrganizationCreateFormData } from "~/types/entities/organization"; | |||
import {Toaster, toast } from 'vue-sonner' | |||
import BtnAction from "~/components/btn/action/BtnAction.vue"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick note that we don't need to import the component in Nuxt, but then I think this was likely an auto import? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I didn't even realize that it was added to the imports 😄.
Quick note here, @to-sta: I'm not able to navigate to the organization about page post creation with the current state of things. I can take a look at this a bit later when I fix the |
What was the response? I just checked if I removed the redirect, but it is still in their and it works fine on my end. It could be the db volume since the models have changed. |
I'll give it another shot on Sunday and let you know :) Thanks for the note that it's working on your end! |
Contributor checklist
Description
I adjusted the org API to create the OrganizationText for POST requests.
ToDo:
Related issue