-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#354 #346 composable state for menu/sidebar components. #535
#354 #346 composable state for menu/sidebar components. #535
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
Hey @Robert-Kovalcuk 👋 Confusingly this isn't the spaces at the end of the file alone, but it's actually reverting the i18n changes as I'd feared. Not really sure what to do here 🤔 The version of the frontend you copied over has the old i18n keys, so because of that it's overwriting the new ones as you copied it into a fresh fork of the repo. Easiest would likely be to only copy the files that are for this issue over and then I can go through and fix the i18n keys in them if need be? |
The no such file or directory for i18n is also because your fork has the old version/name of that file :) |
But I remember that I pulled the commit with the i18n while we were on a call. Hmm, let's figure it out tomorrow? |
Ya it's very confusing. I remember you did that too. But ya, we can check it all tomorrow 😊 Thanks and till then! |
Closing this due to new version in #539 :) |
Contributor checklist
Description
Related issue