Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#354 #346 composable state for menu/sidebar components. #535

Closed
wants to merge 1 commit into from
Closed

#354 #346 composable state for menu/sidebar components. #535

wants to merge 1 commit into from

Conversation

Robert-Kovalcuk
Copy link
Contributor

Contributor checklist


Description

Related issue

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 8186bf4
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/654d64fdf1b7ec0008bf9ed5
😎 Deploy Preview https://deploy-preview-535--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review November 9, 2023 23:02
@andrewtavis
Copy link
Member

Hey @Robert-Kovalcuk 👋 Confusingly this isn't the spaces at the end of the file alone, but it's actually reverting the i18n changes as I'd feared. Not really sure what to do here 🤔 The version of the frontend you copied over has the old i18n keys, so because of that it's overwriting the new ones as you copied it into a fresh fork of the repo. Easiest would likely be to only copy the files that are for this issue over and then I can go through and fix the i18n keys in them if need be?

@andrewtavis
Copy link
Member

The no such file or directory for i18n is also because your fork has the old version/name of that file :)

@Robert-Kovalcuk
Copy link
Contributor Author

But I remember that I pulled the commit with the i18n while we were on a call. Hmm, let's figure it out tomorrow?

@andrewtavis
Copy link
Member

Ya it's very confusing. I remember you did that too. But ya, we can check it all tomorrow 😊 Thanks and till then!

@andrewtavis
Copy link
Member

Closing this due to new version in #539 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants