refac: Remove unnecessary triggers and steps in GitHub Actions

[wkyoshida]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

Working on #429 , I noticed a couple points in our existing workflows:

• Was wondering if the Checkout step was necessary in the pr_maintainer_checklist.yaml, since the workflow doesn't perform any steps actually involving the source code. Tried removing this step and tested in my fork:

  • Test PR: test: TESTING pr_maintainer_checklist wkyoshida/activist#1
  • Notice in the logs that the workflow does not perform the Checkout step and still succeeds 🚀

• Also, the workflow_run triggers in the pr_ci_backend.yaml and the pr_ci_frontend.yaml appear to be redundant, since there is already a trigger for when the pull_request is opened. The pr_maintainer_checklist workflow is completed mere seconds after the pull_request is opened, so this simply causes an unnecessary duplicate CI run.

  • Notice the duplicate pr_ci_backend and pr_ci_frontend runs for the PR yesterday created for 🌿
    
  • Notice in the test PR from above, no duplicate CI runs occur 😁
    

Related issue

• #ISSUE_NUMBER ?
  • Unsure... Discussion (and potential setup) of ability to self-assign issues #429 ? As I was working on that when uncovered these items.. or another issue can be created. Either or

[github-actions]

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

• The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[netlify]

✅ Deploy Preview for activist-org canceled.

Name	Link
🔨 Latest commit	52ae4d7
🔍 Latest deploy log	https://app.netlify.com/sites/activist-org/deploys/6541a851d974c30009bebd3c

[wkyoshida]

Likely not dire in our current situation, but thought of this refac to avoid unnecessary GitHub Actions usage, as there is in fact a limit on used minutes.

[andrewtavis]

Thanks for the consideration on this, @wkyoshida! :) Great to cut it down as we can 😊

[andrewtavis]

Makes sense and looks good to me, @wkyoshida! If there's something like this on the Scribe end, could you also open PRs? Thanks! 🙏