Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create topic dropdown component #497

Merged

Conversation

iagocarmona
Copy link
Contributor

Contributor checklist


Description

Creating component dropdown topics

Closed dropdown
image

Opened dropdown
image

Hovered item
image

Possible props

  defineProps<{
    topic: string;
    hasIcon?: boolean;
    iconName?: string;
    isRounded?: boolean;
    items: string[];
  }>();

Related issue

I was thinking about adding a new property to talk about whether the dropdown will override the others, but I would like your opinion first.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 44906fc
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/655e2079d07dee00084657e4
😎 Deploy Preview https://deploy-preview-497--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review October 24, 2023 21:16
@andrewtavis
Copy link
Member

Hey @iagocarmona 👋 Looking really good so far! I wanted to check in with you on some options for this, and am glad you sent along some questions/suggestions 😊 What do you think about adding in typing functionality to the select functionality via Headless UI's combobox?

I was thinking about adding a new property to talk about whether the dropdown will override the others, but I would like your opinion first.

Do you mean that the selected one would be the label? We could do that with the combobox, or what I was thinking was also to allow the user to select more than one? This section of the docs shows how we can select more than one. We'd then maintain the label of the component as is.

Let me know how this sounds! I think this would definitely make it easier for the user to quick select things, and filtering by more than one would make searches much easier.

@andrewtavis
Copy link
Member

And what do you think of converting the super long topic selection with all the checkboxes (see sidebar) to something similar to what we're talking above? We could have all the topics in a combobox in the sidebar, and for the component we're working on here it would just be those that the user has indicated as being their favorites in their profile so it's easier for them to select those :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 24, 2023
@andrewtavis
Copy link
Member

Hey @iagocarmona 👋 How are you doing on this issue here? Do you think that a conversion over to Headless UI's combobox is possible? We're trying to use Headless as much as possible to make sure that we have accessibility at a high standard.

@iagocarmona
Copy link
Contributor Author

Hello, Im working on this, I will change to use the this UI. I think it would be better too.

@andrewtavis
Copy link
Member

Thanks @iagocarmona! Looking forward :) I can figure out the merge conflict when you resend as well - no stress. I flattened the i18n JSON so we can search for where we define the key and for all its instances during one all codebase search. Figured it'd be easier to make changes as we can also find and replace now 😊

Hope you're well!

@andrewtavis
Copy link
Member

Hey there, @iagocarmona! Let me know what the plans here are :) I'll deal with the merge conflicts by dropping in the current i18n file before merge, so no stress. We can also check in on this on Saturday during the sync/Code Night if that could work on your end 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iagocarmona 👋 There are a couple things that are relying on this at this point, so I'm going to bring this in and do a refactor for it being a combobox. Thanks for the contribution here! Sorry that the issue wasn't was well defined from the get go :)

@andrewtavis andrewtavis merged commit 064b828 into activist-org:main Nov 22, 2023
6 checks passed
@andrewtavis andrewtavis mentioned this pull request Nov 22, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants