-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FormViewSelector #495
Added FormViewSelector #495
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for this, @bmartins-42! I'll try to get back to you with a review soon :) |
119a31d
to
88a638a
Compare
"marker-private": { | ||
"private": "Private" | ||
"view-selector": { | ||
"title-aria-label": "Select a view type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really really wonderful, @bmartins-42 😊 Thanks for the focus on accessibility!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work here, @bmartins-42 😊 Just tried it out and it's perfect. Hope that the conversion over the Headless UI wasn't too annoying! Would be great to get your feedback on Headless. If you enjoyed using it, then there are a few more conversion issues that were just made, and it'd also be great to see if there are other components that we should be using it in!
Contributor checklist
Description
Added a
FormViewSelector
that is takingv-model
,option1
,option2
as required andoption3
as optionalRelated issue