Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FormViewSelector #495

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

bmartins-42
Copy link
Contributor

Contributor checklist


Description

Added a FormViewSelector that is taking v-model, option1, option2 as required and option3 as optional

image image

Related issue

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 88a638a
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6538d0ec206c5d00084af3d4
😎 Deploy Preview https://deploy-preview-495--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bmartins-42
Copy link
Contributor Author

  • I do not have a lot of experience with A11Y so let me know if the compatibility has to be reworked.
  • I also not sure about the color I used so let me no if I need to change them

@bmartins-42 bmartins-42 marked this pull request as ready for review October 24, 2023 12:00
@andrewtavis andrewtavis self-requested a review October 24, 2023 12:07
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 24, 2023
@andrewtavis
Copy link
Member

Thanks for this, @bmartins-42! I'll try to get back to you with a review soon :)

"marker-private": {
"private": "Private"
"view-selector": {
"title-aria-label": "Select a view type",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really really wonderful, @bmartins-42 😊 Thanks for the focus on accessibility!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work here, @bmartins-42 😊 Just tried it out and it's perfect. Hope that the conversion over the Headless UI wasn't too annoying! Would be great to get your feedback on Headless. If you enjoyed using it, then there are a few more conversion issues that were just made, and it'd also be great to see if there are other components that we should be using it in!

@andrewtavis andrewtavis merged commit 275912a into activist-org:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants