Skip to content

Commit

Permalink
#420 ๐ŸŒฟ minor formatting fixes and remove mypy backend ci reference
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewtavis committed Oct 31, 2023
1 parent e2e5c5c commit 7bce1bf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/pr_ci_backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,3 @@ jobs:
- name: Run ruff - Linting and import sorting check
run: ruff ./backend
continue-on-error: true

This comment has been minimized.

Copy link
@to-sta

to-sta Oct 31, 2023

Collaborator

@andrewtavis It still pointed to the mypy.ini config file. Will make a PR that adds mypy back into the workflow with the new config ๐Ÿ˜…

- name: Run mypy - Static Type Checking
run: mypy ./backend --config-file ./backend/mypy.ini
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,11 @@ activist is very open to contributions from people in the early stages of their
> Alternatively to using HTTPS as in the instructions below, consider SSH to interact with GitHub from the terminal. SSH allows you to connect without a user-pass authentication flow.
>
> To run git commands with SSH, remember then to substitute the HTTPS URL, `https://github.com/...`, with the SSH one, `git@github.com:...`.
>
> - e.g. Cloning now becomes `git clone git@github.com:<your-username>/activist.git`
>
> GitHub also has their documentation on how to [Generate new SSH key](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent). ๐Ÿ”‘
>
> </p>
> </details>
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,11 @@ Note that the Figma file above is the [public facing designs](https://www.figma.
> Alternatively to using HTTPS as in the instructions below, consider SSH to interact with GitHub from the terminal. SSH allows you to connect without a user-pass authentication flow.
>
> To run git commands with SSH, remember then to substitute the HTTPS URL, `https://github.com/...`, with the SSH one, `git@github.com:...`.
>
> - e.g. Cloning now becomes `git clone git@github.com:<your-username>/activist.git`
>
> GitHub also has their documentation on how to [Generate new SSH key](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent). ๐Ÿ”‘
>
> </p>
> </details>
Expand Down

1 comment on commit 7bce1bf

@wkyoshida
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely forgot that emojis can go in commit messages as well ๐Ÿ˜†

Please sign in to comment.