Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict permissions flag #800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MisterTea
Copy link

@MisterTea MisterTea commented Nov 2, 2021

Hey all! Thanks for creating a beautiful and simple logging library.

We use easyloggingpp in Eternal Terminal ( https://github.com/MisterTea/EternalTerminal ) and would like the logs to only be readable by the user and group that created them (especially for logs created by root). This PR adds a compile flag for that.

A couple of points:

  1. I'm not sure if a compile flag is the right approach, but it looked like creating an option would require us to pass the option all the way down to file creation, which could be a much bigger change.
  2. If the flag is on, I try to bring in std::filesystem to ensure that the correct permissions are set on unix and windows. If this is too large of a footprint, we could do it only for unix.

This is a

  • Breaking change
  • New feature
  • Bugfix

I have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant