-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing the tools up2date and adding some new functions #23
base: master
Are you sure you want to change the base?
Conversation
rdm-tools.php
Outdated
if (result.spawnpoints != null) { | ||
result.spawnpoints.forEach(function(item) { | ||
spawnpoints.push(item); | ||
if (item.despawn_sec != null){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of duplicating the marker generation here with a switch for despawn_sec null, we should do something like if (item.despawn_sec != null) { var color = blue } else { var color = red }
Then pass the var to the marker builder. currently youre checking twice for each point, and with spawns being the most prevalant data i'd like to keep it as efficient as possible
README.md
Outdated
* You don't have to have spawns/stops visible on map to perform reporting anymore. | ||
* Revised optimization function - same super simple algorithm, might be better performing though | ||
* Changes to data storage, functions no longer loop through map objects, coordinates for gyms/stops/spawns are stored separately. Should help with performance | ||
* spawnpoint color is different for verified despawn time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix this section's grammar/punctuation to match the rest of the document?
README.md
Outdated
|
||
#### Routing and Drawing | ||
* ![Draw Polygon](assets/map-draw-polygon.png?raw=true) Enables drawing of polygons on the map. | ||
* ![Manual route placement](assets/map-place-circle.png?raw=true) Enables/disables manual placement of route points. Click on the map to drop a route point in the routing layer based on view radius setting. | ||
* ![Import Nests](assets/map-import-nests.png?raw=true) Pulls nest data from OSM and places polygons in the current map bounds covering all parks. | ||
* ![Import Polygon](assets/map-import-polygon.png?raw=true) Import CSV or GeoJSON polygon data. GeoJSON can contain multiple polygons, each one will be placed individually. | ||
* ![Import Polygon](assets/map-import-polygon.png?raw=true) Import CSV or GeoJSON polygon data. GeoJSON can contain multiple polygons, each one will be placed individually. Choose wether to import as editable polygon(s) or nest(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/wether/whether/g ;)
Popups of spawnpoints now show Despawn time: hh:mm:ss instead of seconds.
rdm-tools.php
Outdated
} | ||
|
||
} | ||
|
||
$sql_spawn = "SELECT pokemon_id, COUNT(pokemon_id) as count FROM rdmdb.pokemon WHERE " . $points_string . " AND first_seen_timestamp >= ? GROUP BY pokemon_id ORDER BY count DESC" . $limit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sql-qry needs to be fixed ...
instead of rdmdb.pokemon
use pokemon
this was wrong all along ... kudoo to f.e. DrKendall
thx to un1matr1x
…ts' from settings to 'GO', did some visual changes and added count of points in circles (thx @xxleevo!)
…ving to click each layer.
…emove a bunch of unnecesary stuff from the screen, freeing memory in the process. Also, it looks way cleaner this way.
…ever showing. Also moved the clearLayer from the previous commit to the complete function.
Fix import empty lines
update config.php usage
lift fontawesome version & fix missing icon & change icons for better understanding
…xes for generating circle s2 cells
Password support
Password support
… option for nest import.
update for docker support
create docker workflow
Update docker-compose.example.yml
Summary is in changed README.md
added showing ex-raid-eligible gyms as maroon, thanks to un1matr1x