Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libavformat compatiblity break #1768

Merged
merged 3 commits into from
May 11, 2022
Merged

Fix libavformat compatiblity break #1768

merged 3 commits into from
May 11, 2022

Conversation

B3QL
Copy link
Contributor

@B3QL B3QL commented May 10, 2022

FFmpeg/FFmpeg@b7251ae

Close #1714

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coveralls
Copy link

coveralls commented May 10, 2022

Coverage Status

Coverage remained the same at 84.789% when pulling 2464359 on TraseeHQ:bugfix/1714-fix-ffmpeg-infos-parse into 551e265 on Zulko:master.

@B3QL
Copy link
Contributor Author

B3QL commented May 11, 2022

@mondeja thanks for the review, I fixed flake8 and rebased with master after #1770

tests/test_ffmpeg_reader.py Outdated Show resolved Hide resolved
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! 👍

@B3QL
Copy link
Contributor Author

B3QL commented May 11, 2022

Thanks for the quick feedback loop! Do you have some ETA for the next release?

@mondeja
Copy link
Collaborator

mondeja commented May 11, 2022

Do you have some ETA for the next release?

No idea, I haven't rights in PyPI for this project so I can't release it. I'm just installing from master or refs using GIT urls.

@mondeja mondeja merged commit 5853ff8 into Zulko:master May 11, 2022
@B3QL
Copy link
Contributor Author

B3QL commented May 11, 2022

No idea, I haven't rights in PyPI for this project so I can't release it. I'm just installing from master or refs using GIT urls.

I'm doing the same ;) but would be nice to have a regular release from time to time. The last official release was 1 year ago (2020-05-07).

@tburrows13 is there an ETA for the next release? Can you also consider granting PyPI access for @mondeja since he is actively maintaining the project?

@B3QL B3QL deleted the bugfix/1714-fix-ffmpeg-infos-parse branch May 11, 2022 08:40
@tburrows13
Copy link
Collaborator

tburrows13 commented May 11, 2022

Hello, thanks both for your contributions!

Basically I had a plan for future pre-releases and the v2.0 release (most of which is written in #1089) but a few of the tasks that were blocking the next release never got completed and my life got even more busy! I'm still interested in returning and finishing those tasks - hopefully at the end of June, but it won't be before then.

I do have PyPI access myself but not enough to grant @mondeja access, that would need @Zulko. Or wait a month or so until I can do the next pre-release.

@B3QL
Copy link
Contributor Author

B3QL commented May 11, 2022

Basically I had a plan for future pre-releases and the v2.0 release (most of which is written in #1089) but a few of the tasks that were blocking the next release never got completed and my life got even more busy! I'm still interested in returning and finishing those tasks - hopefully at the end of June, but it won't be before then.

Thanks for your contributions so far! It's understandable that the side OSS project is often time-consuming and it's harder to commit more free time over time.

The end of June looks decent, keeping my finger crossed ;) Any clue about the date for the 2.0.0 release? Or what needs to be delivered until it can be shipped? (I saw the road map #1089)

I do have PyPI access myself but not enough to grant @mondeja access, that would need @Zulko. Or wait a month or so until I can do the next pre-release.

Waiting a month or more it's not a problem here. I see it more as a way of reducing the bus factor and enabling people that want to get more involved. The project is very successful - 15,233 repositories use it, 9.2k stars and it would be great to have some regular releases.

@Zulko please consider sharing more power and responsibility with current contributors, thanks!

@tburrows13
Copy link
Collaborator

Before v2.0.0, as far as I remember it is the 2 outstanding things from #1089 (comment) and the documentation rework (which I think I nearly finished). The original comment in #1089 had some more things but I don't think that they're as important and I'd be happy to release without them.

@B3QL B3QL mentioned this pull request Jul 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in FFmpeg libavformat break FFmpegInfosParser
4 participants