Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Blindsign ui #146

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add support for Blindsign ui #146

merged 2 commits into from
Oct 10, 2024

Conversation

chcmedeiros
Copy link
Collaborator

@chcmedeiros chcmedeiros commented Oct 4, 2024

🔗 zboto Link

@emmanuelm41
Copy link
Member

@chcmedeiros I have some questions:

  • Are we testing this somewhere?
  • Are we adding a new setting to enable blind signing or not? Don't we usually do that with expert mode?
  • Are we adding the setting on compile time, based on a flag? Is this correct?

Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

@chcmedeiros
Copy link
Collaborator Author

Hey @emmanuelm41!

  • We don't have tests for the ui's because they need to be triggered by the apps. I tested it locally on the peaq app;
  • Yes, we are adding this featured at least to peaq. This was a request from ledger, for us to follow the blind sign flow they have on eth app.
  • Yes, we enable a flag on the makefile that will "unlock" the blind sign code

@emmanuelm41 emmanuelm41 merged commit c4c3548 into main Oct 10, 2024
7 checks passed
@emmanuelm41 emmanuelm41 deleted the feat/blindsigning-ui branch October 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants