Re-added sector damage for non-players. #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplements SECMF_HURTMONSTERS and SECMF_HARMINAIR.
Fixes sector damage to either monsters or players not working on (non-)solid 3D floors.
tiltshiftfocus
pushed a commit
to tiltshiftfocus/gzdoom
that referenced
this pull request
Oct 21, 2024
* Re-add non-player sector damage. Reimplements SECMF_HURTMONSTERS and SECMF_HARMINAIR. * Fixed 3D floor handling for sector damage. Fixes sector damage to either monsters or players not working on (non-)solid 3D floors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just entirely reimplements #2479. This time with the behavior on 3D floors that use their control sectors' damage fixed to work like it did in 4.12 for both players and non-players. The hurtmonsters UDMF key now also needs to be added to the 3D floor control sector itself instead of the sector the 3D floor is projected on.
The below example map showcases how several types of damaging sectors affect a Cyberdemon (Ground monster) and Cacodemon (Flying monster). There's 2 normal damaging floors, one with SECMF_HARMINAIR. A solid damaging 3D floor, a floating damaging swimmable 3D floor, and a non-solid damaging 3D floor "pool".
Non-player 3D floor damage.zip