Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add set/get plane reflectivity #2766

Merged
merged 4 commits into from
Oct 26, 2024
Merged

add set/get plane reflectivity #2766

merged 4 commits into from
Oct 26, 2024

Conversation

kevansevans
Copy link
Contributor

Adds both SetPlaneReflectivity and GetPlaneReflectivity to Sector structs

coelckers
coelckers requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@coelckers coelckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the exceptions out of the engine core into the VM wrapper functions.

@kevansevans
Copy link
Contributor Author

Applied change as requested

@RicardoLuis0
Copy link
Collaborator

this last commit seems to have added major formatting changes to r_defs

@kevansevans
Copy link
Contributor Author

I did not notice that and am tremendously confused as to where it came from. Should be cleaned up now.

@RicardoLuis0 RicardoLuis0 merged commit 8b73332 into ZDoom:master Oct 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coelckers coelckers coelckers requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevansevans @RicardoLuis0 @coelckers