Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzers #40

Merged
merged 15 commits into from
Feb 6, 2020
Merged

Add analyzers #40

merged 15 commits into from
Feb 6, 2020

Conversation

sarthakn7
Copy link
Contributor

Added ability to use predefined Lucene analyzers as well as create custom analyzers.
Note:

  1. ConditionalTokenFilter code would compile fine but it's only implementation needs a file as param. Sending a file as a param (i.e. getting file contents, writing it to a file and then using that as a param) isn't supported yet, so this code is useless right now.
  2. The analyzers for suggest haven't been modified here - just using standard analyzer for now.

umeshdangat
umeshdangat reviewed Feb 5, 2020
View reviewed changes
Copy link
Member

@umeshdangat umeshdangat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left minor comments

This was referenced Feb 5, 2020
Open
Open
@sarthakn7 sarthakn7 merged commit 6e2ce1b into master Feb 6, 2020
@sarthakn7 sarthakn7 deleted the add_analyzers branch February 6, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umeshdangat umeshdangat umeshdangat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakn7 @umeshdangat