Add support for stopping containers by image #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
reviewed
Sep 17, 2017
docker_custodian/docker_autostop.py
Outdated
| def build_image_matcher(images): | ||
| def matcher(container): | ||
| return any( | ||
| container.get('Config',{}).get('Image').startswith(image) |
There was a problem hiding this comment.
Doesn't this need to be .get('Image', "") so that startswith is always called on a string?
|
I'm very embarassed to not have run the tests before. Now they pass locally, but on travis I'm getting some pre-commit hook error that I'm unfamiliar with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually don't assign names to our containers, but want to be able to auto-stop them based on the image name instead.