Skip to content

Commit

Permalink
Merge pull request #38 from Yelp/pypi-env-var
Browse files Browse the repository at this point in the history
Use PIP_INDEX_URL if it exists, update Ubuntu builds
  • Loading branch information
chriskuehl authored Nov 17, 2021
2 parents e0a598f + c598e92 commit f2da1b2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ jobs:
- test
- itest_xenial
- itest_bionic
- itest_stretch
- itest_buster
- itest_focal
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
Expand Down
7 changes: 1 addition & 6 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
FROM debian:stretch

# The default mirrors are too flaky to run reliably in CI.
RUN sed -E \
'/security\.debian/! s@http://[^/]+/@http://mirrors.kernel.org/@' \
-i /etc/apt/sources.list
FROM ubuntu:focal

RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
Expand Down
9 changes: 2 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ builddeb:

# itest / docker build
DOCKER_BUILDER := aactivator-builder-$(USER)

# XXX: We must put /tmp on a volume (and then chmod it), or the filesystem
# reports a different device ("filesystem ID") for files than directories,
# which breaks our path safety checks. Probably due to AUFS layering?
DOCKER_RUN_TEST := docker run -e DEBIAN_FRONTEND=noninteractive -v /tmp -v $(PWD):/mnt:ro
DOCKER_RUN_TEST := docker run -e DEBIAN_FRONTEND=noninteractive -e PIP_INDEX_URL -v $(PWD):/mnt:ro

.PHONY: docker-builder-image
docker-builder-image:
Expand All @@ -39,8 +35,7 @@ itest: $(ITEST_TARGETS)

itest_xenial: _itest-ubuntu-xenial
itest_bionic: _itest-ubuntu-bionic
itest_stretch: _itest-debian-stretch
itest_buster: _itest-debian-buster
itest_focal: _itest-ubuntu-focal

_itest-%: builddeb-docker
$(DOCKER_RUN_TEST) $(shell sed 's/-/:/' <<< "$*") /mnt/ci/docker

0 comments on commit f2da1b2

Please sign in to comment.