Initial patch for old files update for WordPress 6.7

[peterwilsoncc]

Trac ticket: https://core.trac.wordpress.org/ticket/62150

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, davidbaumwald, pbiron.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[dream-encode]

@peterwilsoncc Thanks! Looks good so far! Nice to have an early PR to have other folks review.

We'll rerun the ^D and ^A during the Dry Run to make sure the updates here are still the same.

[pbiron]

LGTM. I compared this list of deleted files/dirs against the list generated by WP_CLI when upgrading from 6.6.2 to 6.7-beta3 and they are consistent.

By consistent I mean that WP_CLI deletes individual files like wp-includes/SimplePie/{dir}/{file} and this patch deletes wp-includes/SimplePie/{dir}.

[pbiron]

Not necessary, but wouldn't hurt to add a reference to https://core.trac.wordpress.org/changeset/59141 in this comment.

[peterwilsoncc]

Proposed commit message:

Upgrade/Install: Update the $_old_files array for 6.7.

Update the array of files to be removed during the upgrade routine for WordPress 6.7. The upgrade of the SimplePie library in [59141] included a significant refactor requiring a number directories be removed.

Props, fixes, etc

[pbiron]

Not necessary, but wouldn't hurt to add a reference to https://core.trac.wordpress.org/changeset/59141 in this comment.

I now realize I did something wrong. I meant the above to be "add that reference to comment at the being of the PR that explains about the SimplePie update" ;-)

[peterwilsoncc]

I now realize I did something wrong. I meant the above to be "add that reference to comment at the being of the PR that explains about the SimplePie update" ;-)

Yes, that makes way more sense. Pushed. It's early, that's my excuse for misunderstanding ;)