Added style variations in Purr Theme #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shail-mehta
commented
Jun 29, 2024
shail-mehta
commented
- I have added One Style Variation(verdigris).
- Changed Color palette name in theme.json (Used base, base-2, contrast , contrast-2, contrast-3, accent, accent-2 Instead of particular color name for Reuse name in custom style variation)
- Added Font License Info in readme.txt
- Changed required php version in style.css (added 7.4 same as readme.txt)
- Changed Tested Up to 6.6 in style.css & readme.txt (Because we are already in 6.6 RC1 was already released)
shail-mehta
changed the title
|
Issue: #200 |
MaggieCabrera
requested changes
Jul 1, 2024
shail-mehta
changed the title
|
Added One more Style Variation. ( |
| "fontStyle": "normal", | ||
| "fontWeight": "700", | ||
| "src": [ | ||
| "file:./assets/fonts/dm-sans/DMSans-Bold.woff2" |
There was a problem hiding this comment.
I'm not sure it's a bug with your code but I don't see DM sans on the editor. I do see it applied in the frontend, though
There was a problem hiding this comment.
Its working for me in both editor as well as frontend too.
1. Editor:
2. Front-end:
MaggieCabrera
requested changes
Jul 15, 2024
|
Okay, I will Check both points again. |
|
@MaggieCabrera I have Fixed Color Contrast Issue in Latest Commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.