Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singular page template scaffold #146

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

iamsam2e
Copy link
Collaborator

@iamsam2e iamsam2e commented Mar 7, 2024

version 1 basic scaffold (tested in editor)

version 1 basic scaffold (tested in editor)
@iamsam2e
Copy link
Collaborator Author

iamsam2e commented Mar 7, 2024

Editors note: apologies its been a white since PR'ing to a project this big, im too used to smaller project use of Git.

In reference to work on #142 from Theme session @ WCAsia
Scaffold adds header, empty featured image and title block to start the basic SPT scaffold

image

<!-- /wp:group --></main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer"} /-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"footer"} /-->

We don't need to define the area because it's already defined in theme.json (or should be!)

<!-- /wp:separator -->


<!-- wp:pattern {"slug":"poetry/hidden-post-navigation"} /--></div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist, we should create it! It's fine if we add it to this PR

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really solid. I added a few comments.

One more thing to keep in mind: by deciding to make this a singular template instead of single, we are using the same template for pages and posts, which means posts will not have a comments block. It could be a design decision for this theme, but it feels a little heavy-handed to me.

@MaggieCabrera MaggieCabrera linked an issue Apr 5, 2024 that may be closed by this pull request
@iamsam2e iamsam2e added help wanted Extra attention is needed Theme: Poetry labels Jun 9, 2024
@MaggieCabrera
Copy link
Collaborator

We have similar work done in #142 how can we conflate the two?

Co-authored-by: Maggie <maggie.cabrera@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Theme: Poetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry: Single posts template
2 participants