Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have for a long time added exceptions on when to use --xvfb argument for sitespeed.
first it was for windows, then mac...
Instead of trying to find a new exception, lets just move it to settings and let people set it when needed.
This may be a breaking change if you use linux today, what you have to do is to set
test.sitespeed.xvfb in your own settings.json or temporary set it for this run using the --setting test.sitespeed.xvfb=true argument when starting webperf_core.