Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in wasm2c's tail call optimization codegen #2491

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug in wasm2c's tail call optimization codegen #2491

wants to merge 1 commit into from

Conversation

squk
Copy link
Contributor

@squk squk commented Oct 18, 2024

The default wasm-rt implementation defines wasm_rt_memcpy as memcpy which expects void*

sbc100
sbc100 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the old output code even compile?

@keithw
Copy link
Member

keithw commented Oct 18, 2024

I'm a little confused -- we pass the tail-call tests, so... this suggests we need some additional testing here. How is this code-path not hit by the current tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squk @keithw @sbc100