feat: limit subscription concurrency #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arein
approved these changes
Jan 17, 2024
heilhead
commented
Jan 17, 2024
| .collect::<Vec<_>>(); | ||
|
|
||
| // Limit concurrency to avoid overwhelming the relay with requests. | ||
| const REQUEST_CONCURRENCY: usize = 48; |
There was a problem hiding this comment.
@chris13524 Let's keep an eye on how long the subscription takes and adjust this if needed. It'll definitely take longer than it used to be, but not sure how long.
chris13524
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This limits the relay subscription concurrency to prevent huge database request spikes on reconnections. Also makes use of the new 'blocking' subscriptions. See reown-com/reown-rust#56 and https://github.com/WalletConnect/rs-relay/pull/1387.
How Has This Been Tested?
Untested.
Due Diligence