Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 #2085

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

v4.0.0 #2085

wants to merge 7 commits into from

Conversation

joelhawksley
Copy link
Member

@joelhawksley joelhawksley commented Sep 3, 2024

This PR will contain the breaking changes to ship for v4.0.0. We're still likely a long way's off, but I wanted to start to collect changes we know we'll want to land here. Until decided otherwise, we plan to release v4 on or after April 1, 2025,

Tasks

* Minimum Ruby version is non-EOL per https://www.ruby-lang.org/en/downloads/branches/ (#2086)

* Only support current Rails and Ruby

In further review of the end-of-life dates for Ruby and Rails,
I propose that we target Ruby >= 3.2 and Rails >= 7.1 which will
be the lowest actively supported versions on April 1, 2025. We can
ship v4 on that date.

* remove backwards compat carve-out

* docs update

* merge cleanup

* update CI config

* remove rails version warning

* grammar
joelhawksley and others added 3 commits September 26, 2024 15:32
* remove appraisals for unsupported rails versions

* remove accommodations for Rails < 6.1 in PreviewHelper

* remove support for Rails < 6.1 in Preview layout

* remove old gemfiles

* remove known issue docs for version of rails no longer supported

* remove old rails support in test suite

* simplify render_inline to only support modern Rails

* always include collection_renderer

* remove ruby and rails deprecation warnings in engine.rb

* remove render_monkey_patch

* remove render monkey patch

* update rendering test for rails and ruby deprecations

* remove duplicate components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant