Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to 1.91.0 #1950

Merged
merged 11 commits into from
Jul 8, 2024
Merged

feat: update to 1.91.0 #1950

merged 11 commits into from
Jul 8, 2024

Conversation

daiyam
Copy link
Member

@daiyam daiyam commented Jul 7, 2024

No description provided.

@apainintheneck
Copy link

FYI: v1.91.0 doesn't seem to work on older macs running Catalina or Big Sur. See microsoft/vscode#219893

@daiyam
Copy link
Member Author

daiyam commented Jul 8, 2024

@apainintheneck Thanks for the update. It seems that it's due to the version of macos of their build agent. I won't change ours so it should be fine (I had the same issue before, #1847).
But their fix is to use parallels??? WTF!

@apainintheneck
Copy link

Ah, good to know. I didn't realize that you'd run into that issue before and that it had been resolved. It's understandable that a buggy build for an ancient OS version doesn't get noticed but at the same time it might be a sign of more problems with their build pipeline configuration.

@daiyam
Copy link
Member Author

daiyam commented Jul 8, 2024

@apainintheneck You can find the temp installers at https://github.com/VSCodium/vscodium/actions/runs/9836298705 in the artifacts (at the bottom of the page)

It's working on Big Sur x86 but the issue was with Big Sur on arm...

@daiyam daiyam merged commit 8451268 into VSCodium:master Jul 8, 2024
21 checks passed
@daiyam daiyam deleted the feat-191 branch July 8, 2024 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants