Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to Ubuntu 24.04 #1113

Merged
merged 7 commits into from
May 22, 2024
Merged

Move CI to Ubuntu 24.04 #1113

merged 7 commits into from
May 22, 2024

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented May 21, 2024

Issue

Fixes #1080

Tasks

  • Update Ubuntu base image for CI checks
  • Update compiler versions
  • Debug build errors
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added the CI label May 21, 2024
@jcoupey jcoupey added this to the v1.15.0 milestone May 21, 2024
@jcoupey jcoupey force-pushed the ci/update-os-and-compilers branch from 80b9e27 to 1cc3741 Compare May 22, 2024 08:39
@jcoupey jcoupey force-pushed the ci/update-os-and-compilers branch from 1cc3741 to f9ac2f8 Compare May 22, 2024 08:55
@jcoupey
Copy link
Collaborator Author

jcoupey commented May 22, 2024

Right, so the full workflow is now OK with gcc 13 after:

  • pinning OSRM to current HEAD with hard-coded commit SHA in the GA workflow;
  • adding -DCMAKE_CXX_FLAGS="-Wno-array-bounds to the OSRM build command.

Our next problem is that we do not really check for clang 18 due to a known issue reported in #1098. I'll try to include the changes suggested in #1101 here in order to try and do everything at once.

My expectation is that we'll have everything running then except the OSRM clang 18 build, which we can then focus on.

@jcoupey
Copy link
Collaborator Author

jcoupey commented May 22, 2024

As expected, building OSRM on current master fails with clang 18. The good news is that it's OK with clang 16 and 17 which I just tested locally, so the upgrade (and OS update) is still possible even if we have to wait to be using clang 18.

@jcoupey jcoupey merged commit f853330 into master May 22, 2024
5 checks passed
@jcoupey jcoupey deleted the ci/update-os-and-compilers branch May 22, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OS and compilers in CI
1 participant