Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout action #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkarbowiak
Copy link

No description provided.

@jcoupey
Copy link
Contributor

jcoupey commented Sep 10, 2024

We're still running into the same problem as #84: looks like ubuntu-latest as spelled out in the workflows still trigger 20.04.

@kkarbowiak
Copy link
Author

We're still running into the same problem as #84: looks like ubuntu-latest as spelled out in the workflows still trigger 20.04.

The ubuntu-latest should point to 22.04, but this is just the OS used by the GitHub Runner. The code is built inside a Docker container as configured in the Dockerfile:

FROM debian:bookworm-slim as builder

Changing this to FROM ubuntu:24.04 as builder makes the code compile, but a subsequent step fails.

@jcoupey
Copy link
Contributor

jcoupey commented Sep 10, 2024

My bad, I was indeed messing things between the runner and the actual image…

Bookworm has gcc 12 which does not support format. We want gcc 13 or 14 as used in the upstream CI runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants