Test lockless posm via hooks #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
force-pushed
the
sauce/actions-no-unlock-hook
branch
from
5e998cc
to
87b9da0
Compare
hensha256
reviewed
Aug 4, 2024
hensha256
reviewed
Aug 4, 2024
test/shared/PosmTestSetup.sol
Outdated
| @@ -24,12 +25,26 @@ contract PosmTestSetup is Test, Deployers, DeployPermit2, LiquidityOperations { | |||
| HookSavesDelta hook; | |||
| address hookAddr = address(uint160(Hooks.AFTER_ADD_LIQUIDITY_FLAG | Hooks.AFTER_REMOVE_LIQUIDITY_FLAG)); | |||
|
|
|||
| HookModifyLiquidities hookModifyLiquidities; | |||
| address hookModifyLiquiditiesAddr = | |||
| address(uint160(Hooks.BEFORE_SWAP_FLAG | Hooks.AFTER_ADD_LIQUIDITY_FLAG | Hooks.AFTER_REMOVE_LIQUIDITY_FLAG)); | |||
There was a problem hiding this comment.
it only has a before swap hook?
There was a problem hiding this comment.
it inherits HookSavesDelta
i wrote a test where if a hook burns a position, it should have the principal capital of the original position. so needed the hook-delta-saving functionality
hensha256
reviewed
Aug 4, 2024
| /// @dev hook can burn liquidity with approval | ||
| function test_hook_burn() public { | ||
| // mint some liquidity that is NOT burned in beforeSwap | ||
| mint(config, 100e18, address(this), ZERO_BYTES); |
There was a problem hiding this comment.
Whats the point in this mint that doesnt get burned?
There was a problem hiding this comment.
because we're burning a position in beforeSwap, if there is only 1 position the swap will fail haha (all liquidity was burned JIT)
need some "idle" liquidity thats untouched for the swap to succeed
hensha256
approved these changes
Aug 4, 2024
saucepoint
added a commit
that referenced
this pull request
Aug 5, 2024
* actions with no unlock * Test lockless posm via hooks (#266) * test hook which modifiesLiquidities in beforeSwap * test hook modifying liquidity * minor cleanups * test that hooks cannot re-enter modifyLiquidities * hook mints liquidity with modifyLiquidities * PR cmments * rename * rename * Update src/interfaces/IPositionManager.sol Co-authored-by: Sara Reynolds <30504811+snreynolds@users.noreply.github.com> * misc code comments --------- Co-authored-by: saucepoint <saucepoint@protonmail.com> Co-authored-by: saucepoint <98790946+saucepoint@users.noreply.github.com> Co-authored-by: Sara Reynolds <30504811+snreynolds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
hookDatais passed tomodifyLiquidities(lockless posm)Follow up tests:
#265