Decode router params calldata #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
approved these changes
Aug 2, 2024
| @@ -83,6 +87,56 @@ contract CalldataDecoderTest is Test { | |||
| _assertEq(_config, config); | |||
| } | |||
|
|
|||
| function test_fuzz_decodeSwapExactInParams(IV4Router.ExactInputParams calldata _swapParams) public view { | |||
There was a problem hiding this comment.
Ok hm I just had this thought which I think relates to all of these tests... Basically we encode the fuzz, and decode it with the library. But we never decode it regularly... shouldnt we be testing it against abi.decode9) not just the raw passed in data?
ie
_encodedParams = abi.encode(_swapParams)
_params = abi.decode(_encodedParams, IV4Router.ExactInputParams)
and then all the asserts are against _params
but lmk if you dont agree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#199