Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test lockless posm via a hook #265

Open
3 of 7 tasks
saucepoint opened this issue Aug 4, 2024 · 1 comment
Open
3 of 7 tasks

test lockless posm via a hook #265

saucepoint opened this issue Aug 4, 2024 · 1 comment
Assignees
@saucepoint
Labels
posm position manager

Comments

@saucepoint
Copy link
Collaborator

saucepoint commented Aug 4, 2024 •
edited
Loading

Component

Position Manager

Describe the suggested feature and problem it solves.

A scratch space for all the tests related lockless posm + hooks:

  • complex operation: decrease liquidity and mint new position on a tighter range
  • take / take_pair to recipient when decreasing liquidity
  • settle / settle_pair with payer when increasing liquidity
  • test direct calls to modifyLiquidityWithoutUnlock and it reverts bc poolmanager v4 is not unlocked
  • subscribers will revert on reentrancy?
  • liquidity hook functions revert on reentrancy
  • using POSM for arbitrary takes/settles with modifyLiquiditesWithoutUnlock
@saucepoint saucepoint added the posm position manager label Aug 4, 2024
@saucepoint saucepoint self-assigned this Aug 4, 2024
@linear Linear
Copy link

linear bot commented Aug 4, 2024

PROTO-401 test lockless posm via a hook

This was referenced Aug 4, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saucepoint saucepoint

Labels
posm position manager
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saucepoint