allow permit2 to silently fail to avoid dos #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Oct 16, 2024
hensha256
reviewed
Oct 16, 2024
hensha256
reviewed
Oct 17, 2024
| PERMIT2.permit(msgSender(), permitSingle, data); | ||
| (success, output) = address(PERMIT2).call( | ||
| abi.encodeWithSignature( | ||
| 'permit(address,((address,uint160,uint48,uint48),address,uint256),bytes)', |
There was a problem hiding this comment.
auditors: would love to know if theres a better practice as i know encodeWithSignature is considered error-prone. permit is an overloaded function so we cannot use encodeCall
There was a problem hiding this comment.
Nothing comes to mind, unfortunately.
There was a problem hiding this comment.
encodeWithSelector can't be used for the same reason. Could define a separate interface that uniquely defines the permit functions, but it'll complicate the issue as opposed to just inlining it.
There was a problem hiding this comment.
Probably you could use try-catch instead of low-level call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.