Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): integration test for swapping in #378

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(tests): integration test for swapping in #378

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
114bb62
added integration toest for swapping in
jfbloom22 Aug 19, 2024
e128c38
commented out other tests
jfbloom22 Sep 28, 2024
95103bc
Revert "commented out other tests"
jfbloom22 Sep 28, 2024
cebe4fd
improved swap routing by sending wrapped eth directly to the router b…
jfbloom22 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration-tests/UniversalRouter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ describe('UniversalRouter', () => {

const wethAmount = ethers.utils.parseEther('1')

planner.addCommand(CommandType.WRAP_ETH, [alice.address, wethAmount])
planner.addCommand(CommandType.WRAP_ETH, [router.address, wethAmount])
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally had
planner.addCommand(CommandType.WRAP_ETH, [alice.address, wethAmount])
but I believe it is ideal to send the wrapped ETH to the router before using it to swap for DAI. Can anyone confirm?

planner.addCommand(CommandType.V2_SWAP_EXACT_IN, [
alice.address,
wethAmount,
Expand Down