CURA-10951_gh_build_curapackage #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan test and build environment configuration has been revised and optimized. The commit includes changes in imports, dependencies, defining build requirements, generating virtual environments etc. Amended to support more strongly typed Conan feature, supporting cross-compilation, improving auto-detection settings for compiler abilities, and improving overall Conanfile structure. This change aims to improve build performance, reduce potential issues and make the project more maintainable. contributes to CURA-10951
requirements are specified in conanfile.py directly contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
no longer used in conan 2.0 contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
3 tasks
rburema
approved these changes
Sep 8, 2023
|
|
||
| required_conan_version = ">=1.50.0" | ||
|
|
||
| required_conan_version = ">=1.56.0" |
There was a problem hiding this comment.
Per your own writeup, which mentions 1.57 and smaller as divergent in behaviour from what we've done for the repo's now, shouldn't this be >=1.58.0 instead?
You wrote:
... because conan <= 1.57 didn't create the build folder before the sip-build was run, ...
(Or maybe you're building this one still in the 'old' way, so we don't have to do that -- I'll look further.)
| pp.blocks["tool_sip_project"].values["sip_files_dir"] = Path("python").as_posix() | ||
| mkdir(self, self.build_path) # FIXME: bad, this should not be necessary | ||
| pp.blocks["tool_sip_project"].values["sip_files_dir"] = str(Path("python").as_posix()) | ||
| # mkdir(self, self.build_path) # FIXME: bad, this should not be necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernized and make use of the new sipbuildtool and pyprojecttoolchain See: Ultimaker/conan-ultimaker-index#8
Merged to main because this is also a problem there, just not visible because of the caching on the runners