Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TOF mashing in SSRB #1464

Merged
merged 18 commits into from
Jul 4, 2024
Merged

Allow TOF mashing in SSRB #1464

merged 18 commits into from
Jul 4, 2024

Commits on Mar 14, 2024

  1. SSRB: add TOF mashing funcionality (BETA)

    @NicoleJurjew
    NicoleJurjew committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e0f906f View commit details
    Browse the repository at this point in the history

  2. SSRB: formatting (clang)

    @NicoleJurjew
    NicoleJurjew committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    80d983b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. SSRB: include number of TOF bins to combine added in utility

    @NicoleJurjew
    NicoleJurjew committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    854c5c6 View commit details
    Browse the repository at this point in the history

  2. remove check for tof-bins

    @NicoleJurjew
    NicoleJurjew committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b0001ab View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. src/buildblock/SSRB.cxx: bugfix: connect in_tof_bin to out_tof_bin 

    src/utilities/SSRB.cxx: formatting of help doc-string
    @NicoleJurjew
    NicoleJurjew committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    53a0446 View commit details
    Browse the repository at this point in the history

  2. src/buildblock/SSRB.cxx: apply clang format

    @NicoleJurjew
    NicoleJurjew committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    884a65e View commit details
    Browse the repository at this point in the history

  3. src/swig/stir.i & src/swig/stir_projdata.i: add iSSRB and SSRB to the… 

    … SWIG-interface
    @NicoleJurjew
    NicoleJurjew committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    73f1139 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. src/buildblock/SSRB.cxx: corrected normalization

    @NicoleJurjew
    NicoleJurjew committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8948c7a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge remote-tracking branch 'origin/master' into addTOFmash_SSRB

    @NicoleJurjew
    NicoleJurjew committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    edbd193 View commit details
    Browse the repository at this point in the history

  2. add TOF mashing to release notes

    @NicoleJurjew
    NicoleJurjew committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cc787f5 View commit details
    Browse the repository at this point in the history

  3. fix SSRB for nonTOF data

    @NicoleJurjew
    NicoleJurjew committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2493ae0 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. use in/out_bin consistently 

    This results in shorter code, but also consistent.

There was a "problem" in the previous version that the TOF
bin was actually used as tang_pos_num when determining get_m()
(but it didn't create a problem as currently get_m() in independent of both).
    @KrisThielemans
    KrisThielemans committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ba80e3b View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. SSRB: norm should not count TOF bins 

    even if do_norm=1, we should not normalise with the number of TOF bins.
This is because the projectors will take the width of the TOF bin
properly into account. (In contrast, for "span", they don't).
    @KrisThielemans
    KrisThielemans committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d874fbf View commit details
    Browse the repository at this point in the history

  2. make simulate_PET_data_for_tests.sh more flexible 

    add a few arguments and configurable environment variables
to be able to modify the output of the simulation
    @KrisThielemans
    KrisThielemans committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    34c40c8 View commit details
    Browse the repository at this point in the history

  3. avoid caching matrix for forward projection 

    Using the cache has very little impact on run-time for a single forward projection,
but affects memory a lot. This is especially important for TOF.
    @KrisThielemans
    KrisThielemans committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d96d8fc View commit details
    Browse the repository at this point in the history

  4. add recon_test_pack/run_test_SSRB.sh

    @KrisThielemans
    KrisThielemans committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f9cbda3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. convert some old-style warning() to new-style 

    When using a single int as argument, the old style version is
actually not used anymore due to the overload with the verbosity presumably.
So use boost::format
    @KrisThielemans
    KrisThielemans committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    24a9102 View commit details
    Browse the repository at this point in the history

  2. change max_rd for STE test-case 

    span=2, max_rd=2 is unexpected, and leads to a bug in FBP3DRP etc.
Changing to the expected case of max_rd=3 for now.
    @KrisThielemans
    KrisThielemans committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    131f3ad View commit details
    Browse the repository at this point in the history