Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes.improvements (mostly SWIG) #1264

Merged
merged 5 commits into from
Sep 24, 2023

Conversation

KrisThielemans
Copy link
Collaborator

  • one more unitialised variable in ProjMatrixByBinSPECTUB
  • friendlier IterativeReconstruction::set_up()
  • add Succeeded.succeeded() method
  • SWIG (and hence Python)
    • add DetectionPosition(Pair) and reduce warnings
    • make Bin.time_frame_num a variable in Python like other members
    • added RadionuclideDB

- throw as opposed to return Succeeded::no, improving user experience in Python
- more informative messages if anything is wrong
this enables more concise code (avoiding the need for comparing with Succeeded::yes
which is especially verbose in Python).
Also make Bin.time_frame_num a variable in Python like other members
@KrisThielemans KrisThielemans added this to the v5.2 milestone Sep 23, 2023
@KrisThielemans KrisThielemans merged commit e5d45c6 into UCL:master Sep 24, 2023
6 of 7 checks passed
@KrisThielemans KrisThielemans deleted the minorFixesImprovements branch September 24, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant