update Array hierarchy and allocate nD arrays in a contiguous block by default #1236
Commits on May 17, 2024
-
-
allow Vector/Array construction from existing memory
needs more tests
-
-
-
Array: first version that defaults to continuous allocation
Currently only applies to the constructor from an IndexRange. Tests fail due to missing assignment operator. Best to use the copy-and-swap idiom.
-
Array: add move constructors, swap and missing assignment operators
Most of the implementation uses the copy-and-swap idiom. I needed copy-constructors as well, as the default generated ones no longer existed or were inappropriate. We should now be following "the rule of five". This now passes test_Array, including with valgrind.
-
- make sure it works with other STIR classes, not just floats etc - re-instate VectorWithOffset constructors that take both start and end pointers for backwards compatibility
-
Array: remove wrong/not implemented constructors
The NumericVectorWithOffset constructor would only work when T=NUMBER. The 1D Array constructor taking an `elemT*` wasn't implemented yet.
-
Seems that VC gets confused by the new Array::swap, so add std:: explicitly
-
add Array constructor from ptr [ci skip]
make Array:init from ptr private test_Array is crashing due to memory bug in grow
-
Array: first version using shared_ptr<T[]> (WIP)
nD Array's now store the "full" memory via shared_ptr<T[]>. This automates memory management. 1D Array's are still TODO. test_Array now works ok, except for 1D arrays. Some testing code remains in test_Array
-
needed for shared_ptr<T[]>, unless we'd implement deleters ourselves
-
Array: use shared_ptr<T[]> for VectorWithOffset
all Array tests pass
-
-
Array: remove private member _owns_memory_for_data
no longer needed as we're using a shared<T[]> and can test that.
-
Array: clean-up constructors that take existing data
- get rid of copy_data argument for constructors but use sensible defaults - add VectorWithOffset::init such that Array doesn't need to know much
-
-
remove experimental/memory work-around for shared_ptr
This was an attempt to handle pre-C++-17, but it would need work for make_shared. In any case, it isn't available on VS compilers apparently.
-
-
[CMake] fix FindCERN_ROOT to always check version
This was previously only done when finding the CONFIG file
-
-
-
-
Avoid image copies in Parallelproj
if data is contiguous, we don't need an extra copy.
