-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Array hierarchy and allocate nD arrays in a contiguous block by default #1236
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ca1217 - Browse repository at this point
Copy the full SHA 4ca1217View commit details -
allow Vector/Array construction from existing memory
needs more tests
Configuration menu - View commit details
-
Copy full SHA for 1873c9d - Browse repository at this point
Copy the full SHA 1873c9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e9527b - Browse repository at this point
Copy the full SHA 3e9527bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77cbf5a - Browse repository at this point
Copy the full SHA 77cbf5aView commit details -
Array: first version that defaults to continuous allocation
Currently only applies to the constructor from an IndexRange. Tests fail due to missing assignment operator. Best to use the copy-and-swap idiom.
Configuration menu - View commit details
-
Copy full SHA for ae72749 - Browse repository at this point
Copy the full SHA ae72749View commit details -
Array: add move constructors, swap and missing assignment operators
Most of the implementation uses the copy-and-swap idiom. I needed copy-constructors as well, as the default generated ones no longer existed or were inappropriate. We should now be following "the rule of five". This now passes test_Array, including with valgrind.
Configuration menu - View commit details
-
Copy full SHA for 616dbb5 - Browse repository at this point
Copy the full SHA 616dbb5View commit details -
- make sure it works with other STIR classes, not just floats etc - re-instate VectorWithOffset constructors that take both start and end pointers for backwards compatibility
Configuration menu - View commit details
-
Copy full SHA for 49146ce - Browse repository at this point
Copy the full SHA 49146ceView commit details -
Array: remove wrong/not implemented constructors
The NumericVectorWithOffset constructor would only work when T=NUMBER. The 1D Array constructor taking an `elemT*` wasn't implemented yet.
Configuration menu - View commit details
-
Copy full SHA for 86a449c - Browse repository at this point
Copy the full SHA 86a449cView commit details -
Seems that VC gets confused by the new Array::swap, so add std:: explicitly
Configuration menu - View commit details
-
Copy full SHA for 205197c - Browse repository at this point
Copy the full SHA 205197cView commit details -
add Array constructor from ptr [ci skip]
make Array:init from ptr private test_Array is crashing due to memory bug in grow
Configuration menu - View commit details
-
Copy full SHA for bc5a282 - Browse repository at this point
Copy the full SHA bc5a282View commit details -
Array: first version using shared_ptr<T[]> (WIP)
nD Array's now store the "full" memory via shared_ptr<T[]>. This automates memory management. 1D Array's are still TODO. test_Array now works ok, except for 1D arrays. Some testing code remains in test_Array
Configuration menu - View commit details
-
Copy full SHA for a399a96 - Browse repository at this point
Copy the full SHA a399a96View commit details -
needed for shared_ptr<T[]>, unless we'd implement deleters ourselves
Configuration menu - View commit details
-
Copy full SHA for 12cec9a - Browse repository at this point
Copy the full SHA 12cec9aView commit details -
Array: use shared_ptr<T[]> for VectorWithOffset
all Array tests pass
Configuration menu - View commit details
-
Copy full SHA for 3c29a2a - Browse repository at this point
Copy the full SHA 3c29a2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b4db8 - Browse repository at this point
Copy the full SHA f4b4db8View commit details -
Array: remove private member _owns_memory_for_data
no longer needed as we're using a shared<T[]> and can test that.
Configuration menu - View commit details
-
Copy full SHA for 2ba9924 - Browse repository at this point
Copy the full SHA 2ba9924View commit details -
Array: clean-up constructors that take existing data
- get rid of copy_data argument for constructors but use sensible defaults - add VectorWithOffset::init such that Array doesn't need to know much
Configuration menu - View commit details
-
Copy full SHA for 433bd82 - Browse repository at this point
Copy the full SHA 433bd82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ae05b1 - Browse repository at this point
Copy the full SHA 0ae05b1View commit details -
remove experimental/memory work-around for shared_ptr
This was an attempt to handle pre-C++-17, but it would need work for make_shared. In any case, it isn't available on VS compilers apparently.
Configuration menu - View commit details
-
Copy full SHA for 345b0d7 - Browse repository at this point
Copy the full SHA 345b0d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for be32661 - Browse repository at this point
Copy the full SHA be32661View commit details -
[CMake] fix FindCERN_ROOT to always check version
This was previously only done when finding the CONFIG file
Configuration menu - View commit details
-
Copy full SHA for 510e429 - Browse repository at this point
Copy the full SHA 510e429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 715ede8 - Browse repository at this point
Copy the full SHA 715ede8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bf2d13 - Browse repository at this point
Copy the full SHA 4bf2d13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74579af - Browse repository at this point
Copy the full SHA 74579afView commit details -
Avoid image copies in Parallelproj
if data is contiguous, we don't need an extra copy.
Configuration menu - View commit details
-
Copy full SHA for 8752e45 - Browse repository at this point
Copy the full SHA 8752e45View commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae82826 - Browse repository at this point
Copy the full SHA ae82826View commit details