Skip to content

Commit

Permalink
make _already_set_up protected as opposed to private
Browse files Browse the repository at this point in the history
Derived classes should share the same set_up status as the base-class.
  • Loading branch information
KrisThielemans committed Dec 14, 2023
1 parent fd9ad11 commit ea946e4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/include/stir/recon_buildblock/SqrtHessianRowSum.h
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ class SqrtHessianRowSum:
void compute_approximate_Hessian_row_sum();

protected:
bool _already_setup = false;

private:
bool _already_setup = false;

//! Objective function object
shared_ptr<GeneralisedObjectiveFunction<TargetT> > objective_function_sptr;
Expand Down
3 changes: 2 additions & 1 deletion src/include/stir/scatter/ScatterEstimation.h
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,11 @@ class ScatterEstimation: public ParsingObject

std::string output_additive_estimate_prefix;

private:
//! variable to check if we have called set_up()
bool _already_setup;

private:

//! attenuation in 3D
shared_ptr<BinNormalisation> atten_norm_3d_sptr;

Expand Down
2 changes: 1 addition & 1 deletion src/include/stir/scatter/ScatterSimulation.h
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ class ScatterSimulation : public RegisteredObject<ScatterSimulation>
int downsample_scanner_dets;

bool downsample_scanner_bool;
bool _already_set_up;

private:
int total_detectors;
Expand All @@ -446,7 +447,6 @@ class ScatterSimulation : public RegisteredObject<ScatterSimulation>
// numbers that we don't want to recompute all the time
mutable float detector_efficiency_no_scatter;

bool _already_set_up;

//! a function that checks if image sizes are ok
/*! It will call \c error() if not.
Expand Down

0 comments on commit ea946e4

Please sign in to comment.