-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] feature(transformer): Conditional typing #318
Draft
martinjlowm
wants to merge
30
commits into
Typescript-TDD:master
Choose a base branch
from
martinjlowm:feature/conditional-typing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[RFC] feature(transformer): Conditional typing #318
martinjlowm
wants to merge
30
commits into
Typescript-TDD:master
from
martinjlowm:feature/conditional-typing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjlowm
force-pushed
the
feature/conditional-typing
branch
from
May 16, 2020 14:05
8e3e6c0
to
a49fba1
Compare
martinjlowm
changed the title
feature(transformer): Conditional typing [WIP]
feature(transformer): Conditional typing
May 16, 2020
…fferentiate them in conditional typing
…w for overloads with non literal inputs
…k calls of interfaces with call signatures
… and utilize TypeScript's MethodSignature type
…hod signature-based hash
…entifier of a BindingName E.g.: ``` const [[[[[var]]]]] = ... ```
…ed methods as well
…yMap and add a comment to why we can do that
martinjlowm
force-pushed
the
feature/conditional-typing
branch
from
May 19, 2020 20:57
a49fba1
to
e92a2b3
Compare
martinjlowm
changed the title
feature(transformer): Conditional typing
[RFC] feature(transformer): Conditional typing
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: After a recent (write-up) discussion (see https://www.notion.so/RFC-Overload-c5a832ca51654f58a5019bf5507013a7), this PR is on hold. It'll add too much complexity in its current state and the project is not ready for such big changes. Feel free to leave a comment here if you have ideas or proposals for how we can approach this.
edit: Moved this PR into draft. It's blocked by a solution to the issue discussed in #313 on how to pass around mock and function identities.
This PR is based on the work done in #303 and #313 and will emit conditional code (from the test) as follows.
This is based on the test case on the unsupported types page. Thorough tests are to be added.