-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yangPathIgnore
setting
#240
Conversation
f88d537
to
fe170ca
Compare
6bde50c
to
6ebcb0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhuebner Ready for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@esmasth
It will not affect existing users who are not using the new preference, right?
else if (file.name.endsWith('.yang')) | ||
resourceSet.getResource(URI.createFileURI(file.absolutePath), true) | ||
else if (file.name.endsWith('.zip')) { | ||
} else if (file.name.endsWith('.zip')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to check if it is a file isFile
. Otherwise it will match directories named e.g. some.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add isFile
or !isDirectory
check?
I don't think it should affect existing users. |
6ebcb0d
to
e666e92
Compare
This allows for exclusion of specific subdirs or files under the dirs specified via `yangPath`. Also added github ci checks markdown files to fix markdownlint issues. This addresses TypeFox#232 Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
e666e92
to
56543b0
Compare
Thanks @esmasth ! |
This allows for exclusion of specific subdirs or files under the dirs
specified via
yangPath
.Also formatted markdown files to fix markdownlint issues.
This addresses #232
Signed-off-by: Siddharth Sharma siddharth.sharma@ericsson.com