Add yangPathIgnore setting
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmasth
force-pushed
the
esmasth/issue232
branch
from
f88d537
to
fe170ca
Compare
esmasth
force-pushed
the
esmasth/issue232
branch
7 times, most recently
from
6bde50c
to
6ebcb0d
Compare
dhuebner
reviewed
Apr 12, 2024
| else if (file.name.endsWith('.yang')) | ||
| resourceSet.getResource(URI.createFileURI(file.absolutePath), true) | ||
| else if (file.name.endsWith('.zip')) { | ||
| } else if (file.name.endsWith('.zip')) { |
There was a problem hiding this comment.
I think you need to check if it is a file isFile. Otherwise it will match directories named e.g. some.zip
There was a problem hiding this comment.
Fixed in the latest patch
dhuebner
requested changes
Apr 12, 2024
I don't think it should affect existing users. |
esmasth
force-pushed
the
esmasth/issue232
branch
from
6ebcb0d
to
e666e92
Compare
This allows for exclusion of specific subdirs or files under the dirs specified via `yangPath`. Also added github ci checks markdown files to fix markdownlint issues. This addresses TypeFox#232 Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
esmasth
force-pushed
the
esmasth/issue232
branch
from
e666e92
to
56543b0
Compare
dhuebner
approved these changes
Apr 15, 2024
|
Thanks @esmasth ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for exclusion of specific subdirs or files under the dirs
specified via
yangPath.Also formatted markdown files to fix markdownlint issues.
This addresses #232
Signed-off-by: Siddharth Sharma siddharth.sharma@ericsson.com