fixed using function as argument in lox interpreter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Aug 20, 2023
src/interpreter/runner.ts
Outdated
Comment on lines
277
to
278
| return functionValue; | ||
| return functionValue; |
tkueeu
commented
Aug 20, 2023
| @@ -3,7 +3,7 @@ import { BinaryExpression, Expression, isBinaryExpression, isBooleanExpression, | |||
| import { createLoxServices } from "../language-server/lox-module"; | |||
| import { v4 } from 'uuid'; | |||
| import { URI } from "vscode-uri"; | |||
| import { CancellationToken } from "vscode-languageclient"; | |||
| import { CancellationToken } from 'vscode-jsonrpc'; | |||
There was a problem hiding this comment.
Was necessary to import less from vscode, otherwise the full initialization breaks unit test
tkueeu
commented
Aug 20, 2023
|
|
||
| test('Closure 1', async() => { | ||
| const input = ` | ||
| // So far fails with: No variable 'outside' defined |
There was a problem hiding this comment.
maybe failing tests should be commented out and marked with a TODO or FIXME comment?
tkueeu
commented
Aug 20, 2023
| ` | ||
|
|
||
| const ast = await parse(input); | ||
| ast.parseResult; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #4