Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various CI improvements #2375

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Various CI improvements #2375

wants to merge 4 commits into from

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 24, 2024

  • Replace '1.10' with 'min' in CI - closes Use version = "min" in CI #2373

  • Bumps julia-actions/cache to v2 - closes Upgrade julia-actions/cache to v2 #2370

  • I tried to simplify the CI matrix. I'm not sure if it has the desired effect, have to see what happens in CI, but it seems that GitHub are low on runners right now

  • I added one combination to test on 'pre' Julia version, i.e. 1.12 as of the time of writing. I think the release of 1.11 caught us a bit off guard and it might be better to be proactive in the future. We already do this testing in DynamicPPL and I think it makes sense to include it here too.

@penelopeysm
Copy link
Member Author

Matrix still broken (sigh)

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.45%. Comparing base (42189fd) to head (7ea9808).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
+ Coverage   86.39%   86.45%   +0.06%     
==========================================
  Files          22       22              
  Lines        1573     1573              
==========================================
+ Hits         1359     1360       +1     
+ Misses        214      213       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 26, 2024

Pull Request Test Coverage Report for Build 11535736871

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 120 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-7.6%) to 78.749%

Files with Coverage Reduction New Missed Lines %
src/mcmc/hmc.jl 120 0.0%
Totals Coverage Status
Change from base Build 11521973282: -7.6%
Covered Lines: 1234
Relevant Lines: 1567

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use version = "min" in CI Upgrade julia-actions/cache to v2
2 participants