-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various CI improvements #2375
Draft
penelopeysm
wants to merge
4
commits into
master
Choose a base branch
from
py/gha
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Various CI improvements #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix still broken (sigh) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2375 +/- ##
==========================================
+ Coverage 86.39% 86.45% +0.06%
==========================================
Files 22 22
Lines 1573 1573
==========================================
+ Hits 1359 1360 +1
+ Misses 214 213 -1 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11535736871Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace '1.10' with 'min' in CI - closes Use version = "min" in CI #2373
Bumps julia-actions/cache to v2 - closes Upgrade julia-actions/cache to v2 #2370
I tried to simplify the CI matrix. I'm not sure if it has the desired effect, have to see what happens in CI, but it seems that GitHub are low on runners right now
I added one combination to test on 'pre' Julia version, i.e. 1.12 as of the time of writing. I think the release of 1.11 caught us a bit off guard and it might be better to be proactive in the future. We already do this testing in DynamicPPL and I think it makes sense to include it here too.