Fix issues found by David in #325 #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebai
commented
Jul 20, 2023
| - `HMCDA(n_adapts::Int=n_adapts, δ::Float64=δ, λ::Float64=λ)` | ||
| - [v0.5.0] **Breaking!** Convenience constructors for common samplers changed to: | ||
| - `HMC(init_ϵ, n_leapfrog)` | ||
| - `NUTS(n_adapts, target_acceptance)` |
There was a problem hiding this comment.
I am unsure if we want to hardcode n_adapts as part of the algorithm. Like the number of MCMC samples, the number of adaption steps should be an argument passed to the AbstractMCMC.sample function.
Related: abstract MCMC PR
|
I have also spotted a bug while writing the ReadMe and solved it this PR #329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: