Skip to content

Commit

Permalink
Update design_notes/interface_for_gibbs.md
Browse files Browse the repository at this point in the history
  • Loading branch information
sunxd3 authored Oct 17, 2024
1 parent 5127bc8 commit 9e946c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion design_notes/interface_for_gibbs.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ For situations where model-specific details are required to compute the log dens

### Regarding `AbstractPPL.condition`

While the `condition` function is a promising idea for Gibbs sampling, it is not currently being utilized in _Turing.jl_'s implementation. Instead, _Turing.jl_ uses a `GibbsContext` for reasons outlined [here](https://github.com/TuringLang/Turing.jl/blob/3c91eec43176d26048b810aae0f6f2fac0686cfa/src/experimental/gibbs.jl#L1-L12). Additionally, _JuliaBUGS_ requires caching the Markov blanket when calling `condition`, which means the proposed `Gibbs` implementation in this PR would not be fully compatible.
While the `condition` function is a promising idea for Gibbs sampling, it is not currently being utilized in _Turing.jl_'s implementation. Instead, _Turing.jl_ uses a `GibbsContext` for reasons outlined [here](https://github.com/TuringLang/Turing.jl/blob/3c91eec43176d26048b810aae0f6f2fac0686cfa/src/experimental/gibbs.jl#L1-L12). Additionally, _JuliaBUGS_ requires caching the Markov blanket when calling `condition`, which means the proposed `Gibbs` implementation in the PR above would not be fully compatible.

### Samplers Should Not Manage Variable Names

Expand Down

0 comments on commit 9e946c0

Please sign in to comment.