Merge pull request #143 from TrustNXT/bugfix/validationresult-success…

…-field Populate success field of ValidationResult entries
TrustNXT · Oct 21, 2024 · 1f08687 · 1f08687
2 parents 8d98471 + df61eb6
commit 1f08687
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/forty-ducks-eat.md b/.changeset/forty-ducks-eat.md
@@ -0,0 +1,5 @@
+---
+'@trustnxt/c2pa-ts': patch
+---
+
+Populate success field of ValidationResult entries
diff --git a/src/manifest/ValidationResult.ts b/src/manifest/ValidationResult.ts
@@ -18,11 +18,12 @@ export class ValidationResult {
      */
     public isValid = true;
 
-    private add(code: ValidationStatusCode, uri?: JUMBF.IBox | string, explanation?: string) {
+    private add(code: ValidationStatusCode, uri?: JUMBF.IBox | string, explanation?: string, success = false) {
         this.statusEntries.push({
             code,
             url: typeof uri === 'string' ? uri : this.getURIFromBox(uri),
             explanation,
+            success,
         });
     }
 
@@ -38,7 +39,7 @@ export class ValidationResult {
      * @param explanation Optional further human-readable explanation of the status
      */
     public addInformational(code: ValidationStatusCode, uri?: JUMBF.IBox | string, explanation?: string) {
-        this.add(code, uri, explanation);
+        this.add(code, uri, explanation, true);
     }
 
     /**

diff --git a/tests/jpeg-signing.test.ts b/tests/jpeg-signing.test.ts
@@ -122,26 +122,31 @@ describe('Functional Signing Tests', function () {
                         code: ValidationStatusCode.TimeStampTrusted,
                         explanation: undefined,
                         url: `self#jumbf=/c2pa/${manifest.label}/c2pa.signature`,
+                        success: true,
                     },
                     {
                         code: ValidationStatusCode.SigningCredentialTrusted,
                         explanation: undefined,
                         url: `self#jumbf=/c2pa/${manifest.label}/c2pa.signature`,
+                        success: true,
                     },
                     {
                         code: ValidationStatusCode.ClaimSignatureValidated,
                         explanation: undefined,
                         url: `self#jumbf=/c2pa/${manifest.label}/c2pa.signature`,
+                        success: true,
                     },
                     {
                         code: ValidationStatusCode.AssertionHashedURIMatch,
                         explanation: undefined,
                         url: 'self#jumbf=c2pa.assertions/c2pa.hash.data',
+                        success: true,
                     },
                     {
                         code: ValidationStatusCode.AssertionDataHashMatch,
                         explanation: undefined,
                         url: `self#jumbf=/c2pa/${manifest.label}/c2pa.assertions/c2pa.hash.data`,
+                        success: true,
                     },
                 ]);