Merge pull request #448 from TimeWarpEngineering/Cramer/2024-07-23/Next

remove Time Travel Support
TimeWarpEngineering · Jul 23, 2024 · 772a73e · 772a73e
2 parents 09c72c2 + 7f807dd
commit 772a73e
Show file tree

Hide file tree

Showing 15 changed files with 171 additions and 273 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,7 +1,7 @@
 <Project>
   <!-- Set common properties regarding assembly information and nuget packages -->
   <PropertyGroup>
-    <TimeWarpStateVersion>11.0.0-beta.63+8.0.303</TimeWarpStateVersion>
+    <TimeWarpStateVersion>11.0.0-beta.64+8.0.303</TimeWarpStateVersion>
     <Authors>Steven T. Cramer</Authors>
     <Product>TimeWarp State</Product>
     <PackageVersion>$(TimeWarpStateVersion)</PackageVersion>

diff --git a/Source/TimeWarp.State/Extensions/ServiceCollectionExtensions.cs b/Source/TimeWarp.State/Extensions/ServiceCollectionExtensions.cs
@@ -165,7 +165,6 @@ public static TimeWarpStateOptions UseReduxDevTools
     serviceCollection.AddScoped<ReduxDevToolsInterop>();
 
     serviceCollection.AddTransient<IRequestHandler<CommitRequest>, CommitHandler>();
-    serviceCollection.AddTransient<IRequestHandler<JumpToStateRequest>, JumpToStateHandler>();
     serviceCollection.AddTransient<IRequestHandler<StartRequest>, StartHandler>();
     serviceCollection.AddScoped(serviceProvider => (IReduxDevToolsStore)serviceProvider.GetRequiredService<IStore>());
 

diff --git a/Source/TimeWarp.State/Features/CloneState/Pipeline/StateTransactionBehavior.cs b/Source/TimeWarp.State/Features/CloneState/Pipeline/StateTransactionBehavior.cs
@@ -60,7 +60,7 @@ CancellationToken cancellationToken
         (
           (ex, path, _, _) =>
           {
-            Logger.LogDebug("Cloning error: {path} {Message}", path, ex.Message);
+            Logger.LogWarning("Cloning error: {path} {Message}", path, ex.Message);
           }
         );
 
@@ -75,7 +75,7 @@ CancellationToken cancellationToken
     Logger.LogDebug
     (
       EventIds.StateTransactionBehavior_Cloning,
-      "Clone State of type {declaringType} originalState.Guid:{originalState_Guid} newState.Guid:{newState_Guid}",
+      "Cloned State of type {declaringType} originalState.Guid:{originalState_Guid} newState.Guid:{newState_Guid}",
       enclosingStateType,
       originalState.Guid,
       newState.Guid

diff --git a/Source/TimeWarp.State/Features/ReduxDevTools/Components/IDevToolsComponent.cs b/Source/TimeWarp.State/Features/ReduxDevTools/Components/IDevToolsComponent.cs
diff --git a/...ponents/TimeWarpStateDevToolsComponent.cs → ...s/Components/TimeWarpStateDevComponent.cs b/...ponents/TimeWarpStateDevToolsComponent.cs → ...s/Components/TimeWarpStateDevComponent.cs
@@ -1,26 +1,14 @@
 namespace TimeWarp.Features.ReduxDevTools;
 
 /// <summary>
-/// Base implementation of IDevToolsComponent. Required for TimeTravel in ReduxDevTools
+/// Adds a RenderModeDisplay RenderFragment to the TimeWarpStateComponent
 /// </summary>
-/// <remarks>See Peter Morris Issue on Blazor
-/// https://github.com/aspnet/Blazor/issues/704
-/// If one implements their own base class with these interfaces
-/// They won't be forced to use this one.
-/// C# 8 with default implementations of interfaces will be quite tempting to solve this.
-/// </remarks>
-public class TimeWarpStateDevToolsComponent : TimeWarpStateComponent,
-  IDevToolsComponent
+public class TimeWarpStateDevComponent : TimeWarpStateComponent
 {
   protected readonly RenderFragment RenderModeDisplay;
-  protected override void OnInitialized()
-  {
-    base.OnInitialized();
-    Subscriptions.Add<IDevToolsComponent>(this);
-  }
 
   protected string RenderModeDisplayString => $"CurrentRenderMode: {CurrentRenderMode}\nConfiguredRenderMode: {ConfiguredRenderMode}";
-  protected TimeWarpStateDevToolsComponent()
+  protected TimeWarpStateDevComponent()
   {
     RenderModeDisplay = builder =>
     {

diff --git a/...e/TimeWarp.State/Features/ReduxDevTools/Components/TimeWarpStateDevToolsInputComponent.cs b/...e/TimeWarp.State/Features/ReduxDevTools/Components/TimeWarpStateDevToolsInputComponent.cs
diff --git a/Source/TimeWarp.State/Features/ReduxDevTools/ReduxDevToolsInterop.cs b/Source/TimeWarp.State/Features/ReduxDevTools/ReduxDevToolsInterop.cs
@@ -10,9 +10,7 @@ public class ReduxDevToolsInterop
   private readonly ReduxDevToolsOptions ReduxDevToolsOptions;
 
   private bool IsInitialized;
-
-  private bool IsEnabled { get; set; }
-
+  private bool IsEnabled;
 
   public ReduxDevToolsInterop
   (

diff --git a/Source/TimeWarp.State/Features/ReduxDevTools/Requests/JumpToState/JumpToStateHandler.cs b/Source/TimeWarp.State/Features/ReduxDevTools/Requests/JumpToState/JumpToStateHandler.cs
diff --git a/Source/TimeWarp.State/Features/ReduxDevTools/Requests/JumpToState/JumpToStateRequest.cs b/Source/TimeWarp.State/Features/ReduxDevTools/Requests/JumpToState/JumpToStateRequest.cs