Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes obsolete code and adds comments in AIGroup::Group_Tighten_To_Position #937

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bobtista
Copy link
Contributor

Addresses #915

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5529abc) 2.97% compared to head (4799ded) 2.97%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop    #937   +/-   ##
=======================================
  Coverage     2.97%   2.97%           
=======================================
  Files          803     803           
  Lines        80345   80340    -5     
  Branches     13761   13760    -1     
=======================================
  Hits          2387    2387           
+ Misses       77615   77609    -6     
- Partials       343     344    +1     
Impacted Files Coverage Δ
src/game/logic/ai/aigroup.cpp 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xezon xezon changed the title removes obsolete code, adds comments for readability Removes obsolete code, adds comments for readability in AIGroup::Group_Tighten_To_Position May 28, 2023
@xezon xezon changed the title Removes obsolete code, adds comments for readability in AIGroup::Group_Tighten_To_Position Removes obsolete code and adds comments in AIGroup::Group_Tighten_To_Position May 28, 2023
@bobtista bobtista force-pushed the cleanUpGroupTightenToPosition branch from a1f5d61 to 4799ded Compare May 28, 2023 18:16
@xezon
Copy link
Contributor

xezon commented May 28, 2023

Change looks ok. Does not need to be merged before Standalone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants