Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in WorldHeightMap::Parse_Blend_Tile_Data function #1112

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Feb 11, 2024

This is addressing supposed original game bug.

tomsons26

indeed it's a bug in original, not too sure if this should be accepted, don't know the implications of fixing this..

I unclear what this does. is_blend_edge_tile member is currently not used in Thyme.

Also a few lines lower is another file read and that also does not set is_blend_edge_tile.

Because is_blend_edge_tile is a legacy thing that would need to be removed entirely.

@xezon xezon added bug investigate Investigation and careful discussion needed vanilla-bug and removed bug labels Feb 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cfa005f) 2.53% compared to head (f76a1da) 2.53%.

Files Patch % Lines
src/platform/w3dengine/client/worldheightmap.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1112   +/-   ##
========================================
  Coverage     2.53%    2.53%           
========================================
  Files          949      949           
  Lines       110299   110299           
  Branches     18881    18881           
========================================
  Hits          2800     2800           
  Misses      107095   107095           
  Partials       404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonwil jonwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved.

Copy link
Contributor

@jonwil jonwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, I mis-read it. Original does not set is_blend_edge_tile. Original code in WB that outputs the value that we are reading and ignoring outputs hardcoded 0. So the fix there is incorrect.

The change from 0xFFFFFFFF to -1 is fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Investigation and careful discussion needed vanilla-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants