Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor File::Print function #1100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Feb 10, 2024

This change refactors the File::Print function. The result of the function is unchanged.

What does it achieve?

  1. buffer[10240] is put on stack only when so required.
  2. Execution flow is simplified. There is only one call to va_end now with no early returns.
  3. Code comments are improved.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (dbfc5bc) 2.53% compared to head (177cf81) 2.53%.

Files Patch % Lines
src/game/common/system/file.cpp 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1100   +/-   ##
========================================
  Coverage     2.53%    2.53%           
========================================
  Files          949      949           
  Lines       110293   110292    -1     
  Branches     18881    18881           
========================================
  Hits          2800     2800           
+ Misses      107089   107088    -1     
  Partials       404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants