Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 2 adding news page #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LAKSHMANANR25
Copy link

@LAKSHMANANR25 LAKSHMANANR25 commented Jun 7, 2020

Fix: #4 i have added UI to news.html using some of the parts from other html files and used some mouseover functions, the last image is also by mouseover

Copy link
Member

@CapTen101 CapTen101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LAKSHMANANR25 kindly provide details of changes you've made, screenshots of any UI changes etc. Always provide description in the PR

@LAKSHMANANR25
Copy link
Author

i have added UI to news.html using some of the parts from other html files and used some mouseover functions, the last image is also by mouseover
SS1
SS2
SS3
SS4

Copy link
Member

@CapTen101 CapTen101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, always try to use an external css and js script file, helps to keep the HTML file clean just like done in #16 . You can take reference from this repository like how we have kept all css, js files etc into separate directories.

Also always mention what issue you are fixing/mentioning like Fix: #<issue-id> so that it can be traced back to the relevant issue. 🙂 @LAKSHMANANR25

@LAKSHMANANR25
Copy link
Author

LAKSHMANANR25 commented Jun 15, 2020

Fix : #4 the ui does not have major changes, i have changed the content from the automated Lorem ipsum, i have then created separate files for css and js,
image
image

@CapTen101
Copy link
Member

nice work! @LAKSHMANANR25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants