Workspaces UI #38
Workspaces UI #38
Conversation
|
all-in-one-without-lb: 
ai-unlimited-without-lb 
all-in-one-nlb 
ai-unilimited-with-nlb 
|
|
The variable Same with the description: |
There was a problem hiding this comment.
There are basically these changes:
- Use
AI Unlimited UIinstead ofWorkspaces UIfor the services name and description - Use the port variables for HTTP (to be renamed) and gRPC instead of hardcoded values
- Use the UI Healthcheck URL, although there is a typo that will be fixed
- Rename the HTTP Port variable name and description to Auth Port
| @@ -461,6 +487,49 @@ Resources: | |||
| docker: | |||
| enabled: "true" | |||
| ensureRunning: "true" | |||
| configure_workspaces_ui_service: | |||
| files: | |||
| /usr/lib/systemd/system/workspaces-ui.service: | |||
There was a problem hiding this comment.
should be ai-unlimited-ui.service instead workspaces-ui.service
There was a problem hiding this comment.
Yes, I was changing the ui name from "workspaces-ui" to "ai-unlimited-ui" and version on my next commit. waiting for the image to be ready and UI fix to test and push them all at once.
| /usr/lib/systemd/system/workspaces-ui.service: | ||
| content: !Sub | | ||
| [Unit] | ||
| Description=workspaces-ui |
There was a problem hiding this comment.
Should be AI Unlimited UI instead of workspaces-ui
| -e TD_VCD_API_PORT=3282 \ | ||
| -e TD_VCD_AUTH_PORT=3000 \ |
There was a problem hiding this comment.
If the HTTP and gRPC Port are a variables, these ports should be too.
-e TD_VCD_AUTH_PORT=${ AiUnlimitedHttpPort } \
-e TD_VCD_API_PORT=${ AiUnlimitedGrpcPort } \
| start_workspaces_ui_service: | ||
| services: | ||
| systemd: | ||
| workspaces-ui: |
There was a problem hiding this comment.
Same here, should be ai-unlimited-ui instead of workspaces-ui
| Value: !Sub http://${ LoadBalancer.DNSName }:${ AiUnlimitedHttpPort } | ||
| Value: !If | ||
| - PortIsNotEighty | ||
| - !Sub "http://${ LoadBalancer.DNSName }:${ AiUnlimitedUiPort }/landing" |
There was a problem hiding this comment.
The UI have a health check too. Use "http://${ LoadBalancer.DNSName }:${ AiUnlimitedUiPort }/healtcheck.
There is a typo, that I will change in a PR this week, should be /healthcheck 😄
| @@ -479,6 +505,49 @@ Resources: | |||
| docker: | |||
| enabled: "true" | |||
| ensureRunning: "true" | |||
| configure_workspaces_ui_service: | |||
| files: | |||
| /usr/lib/systemd/system/workspaces-ui.service: | |||
There was a problem hiding this comment.
same comment about using UI Unlimited instead of Workspaces
| /usr/lib/systemd/system/workspaces-ui.service: | ||
| content: !Sub | | ||
| [Unit] | ||
| Description=workspaces-ui |
There was a problem hiding this comment.
same comment about using UI Unlimited instead of Workspaces
| group: root | ||
| mode: "000400" | ||
| owner: root | ||
| start_workspaces_ui_service: |
There was a problem hiding this comment.
same comment about using UI Unlimited instead of Workspaces
| start_workspaces_ui_service: | ||
| services: | ||
| systemd: | ||
| workspaces-ui: |
There was a problem hiding this comment.
same comment about using UI Unlimited instead of Workspaces
| Value: !Sub http://${ LoadBalancer.DNSName }:${ AiUnlimitedHttpPort } | ||
| Value: !If | ||
| - PortIsNotEighty | ||
| - !Sub "http://${ LoadBalancer.DNSName }:${ AiUnlimitedUiPort }/landing" |
There was a problem hiding this comment.
same comment about using the UI Healthcheck
| -e TD_VCD_API_PORT=3282 \ | ||
| -e TD_VCD_AUTH_PORT=3000 \ |
There was a problem hiding this comment.
API and Auth port hardcoded, should use the variables.
cloud-work535
changed the base branch from
develop
to
feature/add-workspaces-ui-rebase-2
cloud-work535
merged commit 5c6c691
into
feature/add-workspaces-ui-rebase-2
Adding new ui image to the AWS templates. ALB templates are not supported and I have to rollback the ALB template changes. ALB templates will be removed in another PR before the release date.