Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test for issue 176 #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add failing test for issue 176 #177

wants to merge 3 commits into from

Conversation

seva-luchianov
Copy link

@seva-luchianov seva-luchianov commented Oct 28, 2019 •
edited by TehShrike
Loading

TehShrike
TehShrike requested changes Oct 29, 2019
View reviewed changes
Copy link
Owner

@TehShrike TehShrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this project uses tabs for indentation 🐳

test/merge.js Outdated Show resolved Hide resolved
@seva-luchianov @TehShrike
Update test/merge.js
d9ba05e 
Co-Authored-By: Josh Duff <me@JoshDuff.com>
@seva-luchianov
Copy link
Author

My bad about the tabs, forgot I had the autoformatter on :3
Just committed your suggestion about the comparison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TehShrike TehShrike TehShrike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seva-luchianov @TehShrike