#250 [refactor] 엔드포인트 변경, 디자이너 제안 상세보기 response 도메인별로 분리 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Feb 22, 2024
| @Operation(summary = "[JWT] 디자이너 메인 뷰 조회", description = "디자이너 메인 뷰 조회 API입니다.") | ||
| @ApiResponses({ | ||
| @ApiResponse(responseCode = "200", description = "디자이너 메인뷰 조회 성공", content = @Content(schema = @Schema(implementation = DesignerMainResponse.class))), | ||
| @ApiResponse(responseCode = "401", description = "인증 오류 입니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), | ||
| @ApiResponse(responseCode = "500", description = "서버 내부 오류 입니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), | ||
| }) | ||
| @GetMapping(value = "/designer") | ||
| @GetMapping() |
There was a problem hiding this comment.
Suggested change
| @GetMapping() | |
| @GetMapping |
p3 소괄호를 넣지 않아도 /application 으로 엔드포인트가 적용 됩니다!
Comment on lines
58
to
59
| @PostMapping() | ||
| @SecurityRequirement(name = "JWT Auth") |
There was a problem hiding this comment.
p3
소괄호를 넣지 않아도 /model 로 엔드포인트가 적용 됩니다!
| @Operation(summary = "[JWT] 모델 메인 뷰 조회", description = "모델 메인 뷰 조회 API입니다.") | ||
| @ApiResponses({ | ||
| @ApiResponse(responseCode = "200", description = "모델 메인뷰 조회 성공", content = @Content(schema = @Schema(implementation = ModelMainOfferResponse.class))), | ||
| @ApiResponse(responseCode = "401", description = "인증 오류 입니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), | ||
| @ApiResponse(responseCode = "500", description = "서버 내부 오류 입니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), | ||
| }) | ||
| @GetMapping("/model") | ||
| @GetMapping() |
There was a problem hiding this comment.
p3
소괄호를 넣지 않아도 /offer 로 엔드포인트가 적용 됩니다!
|
네에엡! 완료 했습니다~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
*먼저 엔드포인트 변경
* 제안서 상세보기 내용 재조합